Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove audioTrackNumber and change to nonNegativeInteger for numberOf… #343

Closed
wants to merge 1 commit into from

Conversation

MarcAntoine-Arnaud
Copy link
Contributor

…*Tracks

issue #342

Copy link
Collaborator

@JuergenGrupp JuergenGrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MarcAntoine-Arnaud !
No need for duplicate property. No negative number of tracks possible.
@alexander-schulze : Any objections?

@JuergenGrupp
Copy link
Collaborator

EBU EditorialCommittee:
Please re-analyse: audioTrackNumber (in the sense of "index") is NOT the same as hasNumberOfAudioTracks (in the sense of "count").

@JuergenGrupp JuergenGrupp requested a review from tormodv October 21, 2024 15:19
@alexander-schulze
Copy link
Collaborator

Hey @MarcAntoine-Arnaud, @JuergenGrupp
Currently, both audioTrackNumber and numberOfVideoTracks have similar comments in the ontology, but their actual meanings are different:

  • audioTrackNumber refers to a specific audio track in a media file (e.g., track 1 for English audio in a multi-language video).
  • numberOfVideoTracks represents the total number of video tracks available (e.g., two video streams for different camera angles).

If we use these properties for their distinct meanings, we should keep both and update the comments in the ontology to reflect their unique purposes.

However, if the goal is to represent only the total number of tracks, not individual audio tracks, we can remove audioTrackNumber and keep numberOfVideoTracks, which would then represent the total count of both audio and video tracks.

@JuergenGrupp
Copy link
Collaborator

Comment by the Editorial Committee:

  • we need a field for the index of the audio track
  • we need a field for the total count of the audio tracks
  • we should rename those two to the intended meaning

Conclusion: we will decline the pull request, but improve the naming of the properties

@JuergenGrupp
Copy link
Collaborator

This pull request is also related to the issue "Index of track in a MediaResource"
#344
Its resolution should fix #344 also.

@JuergenGrupp
Copy link
Collaborator

This pull request is declined in favor of #369.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants