Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here:
draft-06
.To explain (2), schemasafe in default configuration does not allow schemas that can be proven to have unreachable checks, e.g.
{ "type": "array", "maxLength": 2 }
—maxLength
doesn't do anything on arrays.{ "anyOf": [ { "type": "number" }, {} ] }
— first check doesn't do anything because second always passes.The static check for this one disabled by
allowUnreachable
.allow***
options disable some of those checks, allowing some ill-formed schemas to compile.Those options do not change the runtime behavior of any schemas.
The testsuite includes those ill-formed schemas on a purpose, to test that some parts have no effect on the behavior (assuming they are allowed to compile), and in order to check the runtime behavior here (and compare to the other impls) we have to disable the static checks.