-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare CRAN submission #357
Conversation
Maybe these two are low-hanging fruits:
This one would be really nice, because currently we have done the switch to marginaleffects as a default backend but without fully supporting it (as in having an in-house postprocessing) in easystats/parameters so it feels a bit not-robust as we fully depend on their |
No, we fully support Bayesian models. For Bayesian models, we now call |
For #288, we have to dig a bit more into the |
can't we just like add the following in the format? x <- x[!duplicated(as.list(x))] or x <- x[names(x)[!duplicated(names(x)]] |
Let's wait for #359, which fixes two issues and a bug with ordinal frequentist models we haven't discovered yet. |
Ok, should be good now. |
Half of the package size is the animated gif in the readme 😆 |
Could prolly be removed tbf 🤷 |
Seem to pass |
Ok, feel free to submit (from this PR) |
(I don't want to update all snapshots, so we can ignore this one failing snapshot test for now, since it will resolve with the next marginaleffects update). |
Their linux system is too slow -_- Debian: https://win-builder.r-project.org/incoming_pretest/modelbased_0.9.0_20250119_211448/Debian/00check.log Last released version's CRAN status: OK: 13 CRAN Web: https://cran.r-project.org/package=modelbased Please fix all problems and resubmit a fixed version via the webform. More details are given in the directory: *** Strong rev. depends ***: easystats see Best regards, Flavor: r-devel-linux-x86_64-debian-gcc |
I had the same today with ggeffects. Let's see whether we can skip some tests on CRAN in general, or for Linus specifically. |
Ok, maybe try again... Hopefully, this will be ok now. |
Guess not 😓
|
ok, I'll check some examples. And quickly integrate #360 |
Ups, sorry, merged the wrong PR 🤣 |
@DominiqueMakowski I think we're set for version 0.9.0. WDYT? Are there any urgent issues that need to be fixed before we push a new release on CRAN?
We now default to {marginaleffects}, contrasts were updated, so column names and style is like that for {emmeans}, all relevant stuff should work fine.