fix

easystats · Jan 24, 2025 · 1914649 · 1914649
1 parent 1614c31
commit 1914649
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/R/get_marginalcontrasts.R b/R/get_marginalcontrasts.R
@@ -86,7 +86,10 @@ get_marginalcontrasts <- function(model,
 
   ## TODO: just experimental! Must wait for decision on marginaleffects
   if (utils::packageVersion("marginaleffects") > "0.24.0" && "Parameter" %in% names(out)) {
-    out <- out[duplicated(lapply(out$Parameter, function(i) sort(.split_at_minus_outside_parentheses(i)))), ]
+    redundant_rows <- duplicated(lapply(out$Parameter, function(i) sort(.split_at_minus_outside_parentheses(i))))
+    if (any(redundant_rows)) {
+      out <- out[redundant_rows, ]
+    }
   }
 
   # adjust p-values

diff --git a/tests/testthat/test-estimate_contrasts.R b/tests/testthat/test-estimate_contrasts.R
@@ -419,7 +419,7 @@ test_that("estimate_contrasts - different options for comparison", {
     out,
     c("Level1", "Level2", "Difference", "SE", "CI_low", "CI_high", "z", "p")
   )
-  expect_equal(out$Difference, c(-0.35, 0.8, 0.35, 1.15, 0.7, -0.45), tolerance = 1e-3)
+  expect_equal(out$Difference, c(-0.35, 0.8, 1.15, 0.35, 0.7, -0.45), tolerance = 1e-3)
   out <- estimate_contrasts(dat_glm, contrast = "fa", comparison = "reference", backend = "marginaleffects")
   expect_named(
     out,