Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set username from query string parameter user if present #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moparisthebest
Copy link

This allows links like https://domain/path/to/index/?user=moparisthebest to work without any server side scripting language, example:

https://www.moparcraft.net/skins/?user=moparisthebest

I also changed http: to // for fonts.googleapis.com so it will work regardless of protocol.

@navarr
Copy link
Collaborator

navarr commented Oct 28, 2014

Only concern is that Array.prototype.forEach doesn't exist in IE8 - but also - who cares about IE8?

@moparisthebest
Copy link
Author

It could be implemented without that as well, does this even run in IE8? :)

@earthiverse
Copy link
Owner

It used to run in IE9, not sure if it still does.
Surprisingly, this viewer runs a lot better in IE11 than Chrome on my work computer.

If there's a solution that covers more browsers, I might as well use that solution instead, provided it's not too convoluted.
I wonder if http://stackoverflow.com/questions/11582512/how-to-get-url-parameters-with-javascript/11582513#11582513 is IE8 compatible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants