Mcp23017 driver update #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(fixed some bugs along the way)
gmazzucchi
suggested changes
Dec 2, 2023
mcp23017_driver/mcp23017.h
Outdated
| GET_VALUE_ON_PIN(function_name, REGISTER_A, REGISTER_B) \ | ||
| SET_VALUE_ON_PIN(function_name, REGISTER_A, REGISTER_B) \ | ||
|
|
||
| /// This struct rapresents the MCP23017 device |
mcp23017_driver/mcp23017.h
Outdated
| * @struct MCP23017_t | ||
| * @brief rapresents the MCP23017 device | ||
| */ | ||
| #define GET_VALUE_ON_PIN(function_name, REGISTER_A, REGISTER_B) \ |
There was a problem hiding this comment.
If you want to use the macros, make sure that the user usage is very simple.
int regvalue = GET_REGVALUE(GPPUA);
SET_REGVALUE(GPPUA, 0xA4);
Otherwise it is very complicated to use this driver.
…mcp23017-driver-update" This reverts commit 4a49b7e.
…bs into mcp23017-driver-update
Reverted the code to a previous, stable state due to a wrong merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.