Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): swapped to use marker #2553

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix(list): swapped to use marker #2553

merged 2 commits into from
Feb 4, 2025

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 31, 2025

Fixes #2515

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Changed list-style to be marker for list.css

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: de5b6cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@saiponnada saiponnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Curious on content: "", Is content necessary; won't font-size alone is sufficient?

@ArtBlue
Copy link
Contributor

ArtBlue commented Feb 4, 2025

Looks good to me! Curious on content: "", Is content necessary; won't font-size alone is sufficient?

I could be wrong, but I believe the example of this "trick" that we discovered included content. I don't know the implications of omitting it, but if it doesn't hurt, I'd include it.

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just a selector question.

dist/list/list.css Outdated Show resolved Hide resolved
@agliga agliga merged commit c59f7e6 into 19.1.0 Feb 4, 2025
@agliga agliga deleted the list-changes branch February 4, 2025 21:58
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants