Fix: The snapshot installation blindly applies config to the server. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the server was previously in the member set which was captured in the config of this snapshot, then the peer will appear to have "caught_up" in ::reconfigure. I do not believe there is value in rolling back the config just to reapply it later once log_sync occurs. `::commit_conf` performs a similar check.
szmyd
force-pushed
the
ignore_stale_config_from_snap
branch
from
34eee32 to
daa617d
Compare
greensky00
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server was previously in the member set which was captured in the config of this snapshot, then the peer will appear to have "caught_up" in ::reconfigure. I do not believe there is value in rolling back the config just to reapply it later once log_sync occurs.
::commit_confperforms a similar check.