use log group lower bound as flush key #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besroy
force-pushed
the
fix_truncate_after_restart
branch
3 times, most recently
from
fb5a52e to
fd70a11
Compare
Besroy
force-pushed
the
fix_truncate_after_restart
branch
from
fd70a11 to
85b000a
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 56.51% 66.05% +9.54%
==========================================
Files 108 109 +1
Lines 10300 10983 +683
Branches 1402 1503 +101
==========================================
+ Hits 5821 7255 +1434
+ Misses 3894 3013 -881
- Partials 585 715 +130 ☔ View full report in Codecov by Sentry. |
xiaoxichen
previously approved these changes
Jan 16, 2025
Besroy
force-pushed
the
fix_truncate_after_restart
branch
from
85b000a to
0d2f203
Compare
…stent with the logic in on_write_completion This change prevents truncating more logs than expected.
Besroy
force-pushed
the
fix_truncate_after_restart
branch
from
0d2f203 to
84c888f
Compare
xiaoxichen
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix logic for setting flush_ld_key while loading logs, makes it consistent with the logic in on_write_completion
This change prevents truncating more logs than expected.