Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some improvements regarding pandas 2.2.x futurewarnings and error raises #2477

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

SteffenMeinecke
Copy link
Member

@vogt31337 @KS-HTK @mfranz13 I guess we have not yet started to fix the 2.2.x FutureWarnings for pandas 3 behavior. Here, I started for that short time I had. You can have a look and comment on whether you like my proposal to concat DataFrames with empty_defaults_per_dtype() or not. Regarding the FutureWarning of fillna() and replace(), I like to reference this post which helped me a lot.

KS-HTK
KS-HTK previously approved these changes Dec 5, 2024
@mfranz13
Copy link
Contributor

mfranz13 commented Dec 9, 2024

@SteffenMeinecke I think this is a good approach. Would you mind adding a test?

@SteffenMeinecke
Copy link
Member Author

@SteffenMeinecke I think this is a good approach. Would you mind adding a test?

I fear, I won't have time in the near future.

KS-HTK
KS-HTK previously approved these changes Dec 19, 2024
@SteffenMeinecke SteffenMeinecke mentioned this pull request Dec 19, 2024
6 tasks
@SteffenMeinecke
Copy link
Member Author

@KS-HTK, thanks for approving the previous state. Can you please merge when the tests have passed?

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.87%. Comparing base (f6763c7) to head (9c889e3).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
pandapower/auxiliary.py 60.00% 4 Missing ⚠️
pandapower/sql_io.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2477      +/-   ##
===========================================
- Coverage    75.88%   75.87%   -0.02%     
===========================================
  Files          284      284              
  Lines        33662    33682      +20     
===========================================
+ Hits         25546    25556      +10     
- Misses        8116     8126      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KS-HTK KS-HTK self-requested a review December 20, 2024 07:28
@KS-HTK KS-HTK merged commit f5ce10b into e2nIEE:develop Dec 20, 2024
17 of 25 checks passed
@SteffenMeinecke SteffenMeinecke deleted the fix/pandas_futurewarnings branch January 6, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants