chore: removed swarm init from do-swarm-leader cloud config #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthony-Phothirath
force-pushed
the
do-swarm
branch
from
3ef2bf8 to
2562df6
Compare
opichon
requested changes
Dec 23, 2024
| @@ -64,6 +64,10 @@ setup.portainer: | |||
| @printf "\033[0;3ansible/2m>>> Set up portainer\033[0m\n" | |||
| ansible-playbook plays/portainer.yml | |||
|
|
|||
| setup.swarm: | |||
| @printf "\033[0;3ansible/2m>>> Set up docker swarm\033[0m\n" | |||
| ansible-playbook plays/swarm-init.yml | |||
There was a problem hiding this comment.
the playbook can be named swarm since this is the only swarm-related playbook.
There was a problem hiding this comment.
understood, it will be changed
generators/app/index.js
Outdated
There was a problem hiding this comment.
Why is this part of the MR?
There was a problem hiding this comment.
mistake were made during branch selection
opichon
requested changes
Dec 23, 2024
| - apt update && apt install -y python3-pip |
There was a problem hiding this comment.
it has been moved to packages,
…rm init playbook in ansible generator feat: added combined generators do-swarm generator chore: correction using composeWith instead
Anthony-Phothirath
force-pushed
the
do-swarm
branch
from
1769c32 to
c7e4542
Compare
|
this pull request should be closed, but keep it for now for the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: removed swarm init from do-swarm-leader cloud config,
added swarm-init playbook in ansible-do generator
added make command setup.swarm in ansible-do generator