Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilization and equal-order elements #136

Merged
merged 42 commits into from
Mar 4, 2024
Merged

Stabilization and equal-order elements #136

merged 42 commits into from
Mar 4, 2024

Conversation

jcallaham
Copy link
Collaborator

@jcallaham jcallaham commented Feb 26, 2024

Comparison of original IPCS solver to BDF3 with GLS stabilization and linear velocity elements

Cylinder Pinball Cavity Step
IPCS (nproc=1) 0:57 3:34
IPCS (nproc=4) 0:48 1:50
IPCS (nproc=8) 0:43 1:30
IPCS (nproc=32) 1:15 1:43 1:10:30 13:13
BDF3 (nproc=1) 0:08 0:24
BDF3 (nproc=4) 0:08 0:17
BDF3 (nproc=8) 0:09 0:15
BDF3 (nproc=16) 0:10 0:16 2:00 1:05
Max speedup 5.3x 6x 24.9x 12.2x

TODO:

  • Rebase after BDF/EXT time-stepper #134 is merged (Failed miserably at this)
  • Add stabilization to Newton solver for steady-state
  • Move stabilization definitions to their own classes
  • Allow for setting Krylov solver via BDF solver options (Schur complement PC seems to be best in all cases)
  • How should the environment configuration work? Should we just default to the most efficient settings?
  • Consolidate actuator & BFS noise updates and move to flow (out of scope - see Consolidate actuator & BFS noise updates and move to flow #138)
  • Settle on best constant definition (alfi?)
  • Re-run benchmarks

@jcallaham jcallaham linked an issue Feb 26, 2024 that may be closed by this pull request
@jcallaham jcallaham marked this pull request as ready for review February 29, 2024 11:13
@jcallaham jcallaham changed the title [WIP] Stabilization and equal-order elements Stabilization and equal-order elements Mar 2, 2024
Copy link
Collaborator

@cl126162 cl126162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the SUPG changes and benchmarked it vs IPCS and the BDF. It is more stable compared to the other solvers and works fine.

@cl126162 cl126162 merged commit 5508ac6 into main Mar 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SUPG stabilization and equal-order elements
2 participants