-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilization and equal-order elements #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into jc/bdf-solver
… into jc/bdf-solver
BDF/EXT time-stepper
jcallaham
changed the title
[WIP] Stabilization and equal-order elements
Stabilization and equal-order elements
Mar 2, 2024
cl126162
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the SUPG changes and benchmarked it vs IPCS and the BDF. It is more stable compared to the other solvers and works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison of original IPCS solver to BDF3 with GLS stabilization and linear velocity elements
TODO:
Rebase after BDF/EXT time-stepper #134 is merged(Failed miserably at this)Allow for setting Krylov solver via BDF solver options(Schur complement PC seems to be best in all cases)Consolidate actuator & BFS noise updates and move to flow(out of scope - see Consolidate actuator & BFS noise updates and move to flow #138)