Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(callback): cherrypick callback module #109

Merged
merged 8 commits into from
Aug 13, 2024
Merged

feat(callback): cherrypick callback module #109

merged 8 commits into from
Aug 13, 2024

Conversation

spoo-bar
Copy link
Contributor

…ion of wasm contracts (#99)

Description

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@rockstarRhino @spoo-bar
feat(callback): add callback and cwerrors module for scheduled execut…
ec575f8 
…ion of wasm contracts (dymensionxyz#99)

Co-authored-by: rockstarRhino <“[email protected]”>
Co-authored-by: Spoorthi <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 13, 2024
View reviewed changes
x/cwerrors/abci.go
k.IterateSudoErrorCallbacks(ctx, sudoErrorCallbackExec(ctx, k, wk))
// Prune any error callback subscripitons that have expired in the current block height
if err := k.PruneSubscriptionsEndBlock(ctx); err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
x/cwerrors/abci.go
k.IterateSudoErrorCallbacks(ctx, sudoErrorCallbackExec(ctx, k, wk))
// Prune any error callback subscripitons that have expired in the current block height
if err := k.PruneSubscriptionsEndBlock(ctx); err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
x/cwerrors/abci.go
}
// Prune any errors(in state) that have expired in the current block height
if err := k.PruneErrorsCurrentBlock(ctx); err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
x/cwerrors/abci.go
}
// Prune any errors(in state) that have expired in the current block height
if err := k.PruneErrorsCurrentBlock(ctx); err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
x/cwerrors/module.go

// EndBlock returns the end blocker for the module. It returns no validator updates.
func (a AppModule) EndBlock(ctx sdk.Context, _ abci.RequestEndBlock) []abci.ValidatorUpdate {
return EndBlocker(ctx, a.keeper, a.wasmKeeper)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
@spoo-bar spoo-bar marked this pull request as ready for review August 13, 2024 09:08
@spoo-bar spoo-bar requested a review from a team as a code owner August 13, 2024 09:08
@omritoptix omritoptix changed the title feat(callback): cherrypicking: add callback and cwerrors module for scheduled execut… feat(callback):: cherrypick callback module Aug 13, 2024
@omritoptix omritoptix changed the title feat(callback):: cherrypick callback module feat(callback): cherrypick callback module Aug 13, 2024
@omritoptix omritoptix merged commit a07e899 into dymensionxyz:release/v1.0.x Aug 13, 2024
39 of 42 checks passed
@spoo-bar spoo-bar deleted the spoorthi/adding-callback-module branch August 13, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spoo-bar @omritoptix @rockstarRhino @anhductn2001