fix(abci): use correct hash in abci block.LastCommit.BlockID #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
changed the title
danwt
commented
Jan 9, 2025
Comment on lines
+107
to
110
| // Very old commits may not have a TM signature already. Should run a prior version of | ||
| // dymint to handle them. | ||
| tmCommit.Signatures = append(tmCommit.Signatures, commit.TMSignature) | ||
| return &tmCommit |
There was a problem hiding this comment.
I think it makes sense to remove this, since
- I guess the only blocks without the signatures are very old? Are there even any on mainnet?
- Nowadays you need to be running the right dymint to process old blocks anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Closes https://github.com/dymensionxyz/research/issues/449
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: