Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollback): add rollback support #1300

Merged
merged 2 commits into from
Jan 6, 2025
Merged

feat(rollback): add rollback support #1300

merged 2 commits into from
Jan 6, 2025

Conversation

srene
Copy link
Contributor

@srene srene commented Jan 2, 2025

PR Standards

Opening a pull request should be able to meet the following requirements

This PR enables support for rollback command. It basically does:

  • move updateStateForNextRevision (used for syncing between forks) from NewManager to Start func (to avoid having to set SL layer from rollback func)
  • minor update state refactor

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #1299

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene self-assigned this Jan 2, 2025
@srene srene requested a review from a team as a code owner January 2, 2025 14:18
@srene srene marked this pull request as draft January 2, 2025 14:23
@srene srene marked this pull request as ready for review January 2, 2025 14:46
@danwt
Copy link
Contributor

danwt commented Jan 3, 2025

@danwt danwt merged commit 13816c4 into main Jan 6, 2025
4 checks passed
@danwt danwt deleted the srene/1299-rollback branch January 6, 2025 10:30
danwt pushed a commit that referenced this pull request Jan 9, 2025
danwt pushed a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add rollback support
3 participants