feat(fraud): add "skip validation height" flag #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
requested changes
Dec 23, 2024
block/block.go
Outdated
| m.blockCache.Delete(block.Header.Height) | ||
| // TODO: can we take an action here such as dropping the peer / reducing their reputation? | ||
| return fmt.Errorf("block not valid at height %d, dropping it: err:%w", block.Header.Height, err) | ||
| if m.Conf.SkipValidationHeight == block.Header.Height { |
There was a problem hiding this comment.
Suggested change
| if m.Conf.SkipValidationHeight == block.Header.Height { | |
| if m.Conf.SkipValidationHeight != block.Header.Height { |
omritoptix
reviewed
Dec 23, 2024
proto/types/dymint/state.proto
Outdated
| @@ -51,6 +51,7 @@ message State { | |||
|
|
|||
| int64 revision_start_height = 21; | |||
|
|
|||
| uint32 prev_drs = 23; | |||
There was a problem hiding this comment.
nothing, it was from previous test. removed
mtsitrin
reviewed
Dec 23, 2024
types/state.go
Outdated
| @@ -45,6 +45,8 @@ type State struct { | |||
|
|
|||
| // LastHeaderHash is the hash of the last block header. | |||
| LastHeaderHash [32]byte | |||
|
|
|||
| PrevDrs uint32 | |||
omritoptix
approved these changes
Dec 23, 2024
omritoptix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #XXX
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: