-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(app): move initialization logic outside of the app and into keepers package #975
Merged
mtsitrin
merged 16 commits into
main
from
zale144/paginate-delete-rollapp-packets-refactoring
Jul 15, 2024
Merged
chore(app): move initialization logic outside of the app and into keepers package #975
mtsitrin
merged 16 commits into
main
from
zale144/paginate-delete-rollapp-packets-refactoring
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aginate-delete-rollapp-packets-refactoring
zale144
changed the base branch from
main
to
zale144/paginate-delete-rollapp-packets
July 3, 2024 11:02
zale144
force-pushed
the
zale144/paginate-delete-rollapp-packets-refactoring
branch
from
July 3, 2024 11:36
7af6793
to
5f893bd
Compare
@zale144 please give it a meaningful pr title. thanks. |
zale144
changed the title
chore(app) Further refactor on top of PR #972
chore(app) App refactor after PR #972, move initialization logic outside of the app and into keepers package
Jul 4, 2024
danwt
previously approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice refactor
I understand the keeprs pckage now
omritoptix
changed the title
chore(app) App refactor after PR #972, move initialization logic outside of the app and into keepers package
chore(app): App refactor after PR #972, move initialization logic outside of the app and into keepers package
Jul 8, 2024
omritoptix
changed the title
chore(app): App refactor after PR #972, move initialization logic outside of the app and into keepers package
chore(app): Move initialization logic outside of the app and into keepers package
Jul 8, 2024
omritoptix
changed the title
chore(app): Move initialization logic outside of the app and into keepers package
chore(app): move initialization logic outside of the app and into keepers package
Jul 8, 2024
…te-rollapp-packets-refactoring
mtsitrin
reviewed
Jul 15, 2024
zale144
force-pushed
the
zale144/paginate-delete-rollapp-packets-refactoring
branch
from
July 15, 2024 13:22
fdb319e
to
a551a5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the PR #972 the upgrade handlers are refactored so that they use an interface for the upgrades themselves and keepers are extracted to be in a separate package.
Here we go a step further and move the initializing logic out of
app.go
and into the new packagekeepers
.Closes #320
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval: