Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle case when no code samples are available #18

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

nilslice
Copy link
Member

@nilslice nilslice commented Aug 7, 2024

Just defaults to the "unimplemented" case if no code samples are in the schema.

@nilslice
Copy link
Member Author

nilslice commented Aug 7, 2024

idk why CI is failing with that error from this change, but I'll look into it later!

@nilslice
Copy link
Member Author

nilslice commented Aug 8, 2024

I'll retarget this PR onto #17 once we're ready to flip everything over to the latest v1 schema changes. That should fix the broken CI.

@bhelx bhelx merged commit 56c9764 into main Aug 8, 2024
1 check failed
@nilslice nilslice deleted the fix-no-codesample branch August 8, 2024 21:45
@nilslice
Copy link
Member Author

nilslice commented Aug 8, 2024

Ok, re-ran the tests on main since this was merged and we're all good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants