Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nullable properties that are references to other objects. Update to xtp-bindgen 1.0.0-rc.17 #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Jan 10, 2025

This a is breaking change, maps must now have type: object.

Also add support for various int types.

… to xtp-bindgen 1.0.0-rc.17

This a is breaking change, maps must have `type: object`.
Also add support for various int types.
@G4Vi G4Vi requested review from zshipko and bhelx as code owners January 10, 2025 00:03
@G4Vi
Copy link
Contributor Author

G4Vi commented Jan 10, 2025

Thanks for the review! After realizing adding proper support for required is doable in python (#16 (comment)), I think I'll hold off on merging this until later so after adding those changes in we can release python bindgen without making bindgen changes across the board (required to release the change in this PR.)

G4Vi added a commit that referenced this pull request Jan 10, 2025
…perties

Workaround nullable refs not being handled (fixed in #23)
@G4Vi G4Vi mentioned this pull request Jan 10, 2025
G4Vi added a commit that referenced this pull request Jan 10, 2025
…perties

Workaround nullable refs not being handled (fixed in #23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants