-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] - Add rejson bindings #41
base: master
Are you sure you want to change the base?
Conversation
@nelsonic Hey. Can you please check this pull request and let me know if it can be merged since I need to use ReJSON with my project. The tests seem to be failing for some reason even without any changes. I have added a test for my changes as well. |
@codeslayer1 thanks for opening this feature/pull request. 👍 is rather cryptic in how it's failing ... |
Hey. Thanks for your quick response. Yes. I was able to use ReJSON with my local build. Since I needed this feature urgently, I have published a forked package on npm with rejson (redis-connection-manager). Will revert back to this package once the pull request is merged and an updated version is published. Please let me know in case any help/update is needed at my end to make the tests pass and get this PR merged. |
[![devDependency Status](https://david-dm.org/dwyl/redis-connection/dev-status.svg)](https://david-dm.org/dwyl/redis-connection#info=devDependencies) | ||
<!-- [![HitCount](https://hitt.herokuapp.com/nelsonic/redis-connection.svg)](https://github.com/dwyl/redis-connection) --> | ||
[![npm](https://img.shields.io/npm/v/redis-connection.svg)](https://www.npmjs.com/package/redis-connection) | ||
[![npm](https://img.shields.io/npm/v/redis-connection-manager.svg)](https://www.npmjs.com/package/redis-connection-manager) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codeslayer1 you've pushed changes on this PR which pertain to your forked package. Please revert these before fixing failing tests. 👍
Hey. I have raised a fresh pull request with the Readme and package.json changes that pertain to my package reverted. Please use that new pull request to merge the rejson change. You can delete this pull request. |
Feature:
Use Case: