Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for generating only/no rounded icons #129

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cbrevik
Copy link

@cbrevik cbrevik commented Feb 28, 2020

Resolves #128

Got a bit ahead of discussion in the issue, and just implemented it. Not sure if it fits in the API you want to build for this tool.

@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #129 into master will decrease coverage by 0.79%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   98.23%   97.43%   -0.80%     
==========================================
  Files          16       16              
  Lines         226      234       +8     
==========================================
+ Hits          222      228       +6     
- Misses          4        6       +2     
Impacted Files Coverage Δ
src/validate-parameters.js 93.33% <66.66%> (-6.67%) ⬇️
src/android/generate-manifest-icons.js 95.23% <85.71%> (-4.77%) ⬇️
src/generate.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bef316...15007a7. Read the comment docs.

@lenovouser
Copy link

I need this too. Can the PR be merged?

@dwmkerr
Copy link
Owner

dwmkerr commented Sep 8, 2020

Looks great! Only suggestion, can we make it clear with a code comment what the default behaviour is and add a short update to the README describing the option and how to manage round icons for Android? I don't mind doing the second bit if easier cause I could probably do with updating the docs to describe each parameter in detail anyway!

@cbrevik
Copy link
Author

cbrevik commented Sep 8, 2020

@dwmkerr sure! I added an extra line in the CLI about default behaviour, and some docs as well. Tried to explain it as well as I could. Hope it's adequate 👍

@cbrevik
Copy link
Author

cbrevik commented Oct 20, 2020

@dwmkerr Anything I can do to unblock the PR? 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Own option for round icons?
3 participants