-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for generating only/no rounded icons #129
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 98.23% 97.43% -0.80%
==========================================
Files 16 16
Lines 226 234 +8
==========================================
+ Hits 222 228 +6
- Misses 4 6 +2
Continue to review full report at Codecov.
|
I need this too. Can the PR be merged? |
Looks great! Only suggestion, can we make it clear with a code comment what the default behaviour is and add a short update to the |
@dwmkerr sure! I added an extra line in the CLI about default behaviour, and some docs as well. Tried to explain it as well as I could. Hope it's adequate 👍 |
@dwmkerr Anything I can do to unblock the PR? 😇 |
Resolves #128
Got a bit ahead of discussion in the issue, and just implemented it. Not sure if it fits in the API you want to build for this tool.