Skip to content

Commit

Permalink
Deprecate ICC compiler
Browse files Browse the repository at this point in the history
  • Loading branch information
mikkelfj committed Mar 11, 2024
1 parent c10d0c0 commit 0133894
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/weekly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ jobs:
strategy:
fail-fast: false
matrix:
compiler: [icc, icx]
compiler: [icx]
# ICC is deprecated by Intel and breaks flatcc build which we likely won't fix.
# compiler: [icc, icx]
steps:
- name: Prepare
run: |
Expand Down
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2347,6 +2347,13 @@ See also [issue #274](https://github.com/dvidelabs/flatcc/issues/274).
2024-10-03: Fix available on flatcc master branch when you read this.
See also CHANGELOG comments for release 0.6.2.

2024-03-11:
Intel ICC compiler is deprecated by Intel and the above fix breaks it,
at least for version 2021.4.0 used in current CI build where it is now disabled.
The ICC compiler does not truthfully expose __has_builtin and __has_attribute
which is probably why it fails, but it is hardly worth fixing at this point.
(The cause is suspected to be a call to unimplemented __builtin_memcpy).
Use the Intel ICX compiler instead.

The option `FLATCC_RTONLY` will disable tests and only build the runtime
library.
Expand Down

0 comments on commit 0133894

Please sign in to comment.