Fix "referencing a non existing via_device" when gateway_external_id is None
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Je teste sous peu! Thanks! |
ic-dev21
approved these changes
Feb 10, 2025
|
Fixes #549 |
ic-dev21
added a commit
that referenced
this pull request
Feb 11, 2025
Fix "referencing a non existing `via_device`" when gateway_external_id is None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested on my end adding some logging and the only case it seems to be missing is when the device is the gateway itself.
The fix is to simply not set
via_devicewhengateway_external_idisNone. It's not really useful to specify avia_devicewhen the "device" would basically be itself when we're talking about the gateway itself.From the HA documentation:
via_device: Identifier of a device that routes messages between this device and Home Assistant. Examples of such devices are hubs, or parent devices of a sub-device. This is used to show device topology in Home Assistant.
https://developers.home-assistant.io/docs/device_registry_index/#device-properties
This should fix #549.