Small refactor to fix some lint errors #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting to read the code and I see a lot of underlined code. This annoys me slightly, so I'll make a few small PR like this to try to tackle some of it :)
Starting small with switch.py:
devicevariable so that the properties can be referred to properly.Nonetype ofHiloEntity(in init.py:790). I feel like this should never be None? I tested it and there's no issue in my specific environment, this might require someone else to test it. This was needed otherwise the linter would complain that a null check need to be executed before a lot of things (and its right). Best make it required if we can.There was also some changes in init.py that are being applied automatically (aggressively, I like it) by the dev container setup.