Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 cleanups #366

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Python 3.10 cleanups #366

merged 3 commits into from
Aug 8, 2024

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Aug 8, 2024

  • README: Update for Py3.10+ support
  • tests/helpers: Clean up Py3.6 cruft
  • cli.main: update Python version check

@nbraud
Copy link
Collaborator Author

nbraud commented Aug 8, 2024

@duckinator, do you think we could reasonably make the version check in cli.main use the same source-of-truth as requires-python in pyproject.toml ?

I guess we could ship pyproject.toml in the wheel, and have main just parse it, but there's hopefully a more lightweight way to do it

@nbraud nbraud mentioned this pull request Aug 8, 2024
4 tasks
@duckinator
Copy link
Owner

duckinator commented Aug 8, 2024

Opened #368 about investigating a single source of truth for minimum supported Python version. I'd like to do that, but think it might require some poking around to find a good solution.

@duckinator duckinator merged commit bcdf2d3 into main Aug 8, 2024
20 checks passed
@duckinator duckinator deleted the py3.10 branch August 8, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants