-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed duplicate ojbect for maliciousSiteProtection in macOS override #2737
Conversation
Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
Generated file outputs:Time updated: Fri, 07 Feb 2025 04:56:46 GMT legacytrackers-unprotected-temporary.txt (14 more)
latestv4/android-config.json (13 more)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided the onByDefault
comment is true, this looks good.
@@ -893,14 +893,6 @@ | |||
} | |||
} | |||
}, | |||
"maliciousSiteProtection": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one we're keeping has an additional onByDefault
feature, I imagine that's the one we intend to keep but just wanted to check that's what the clients expect.
"features": {
"onByDefault": {
"state": "enabled"
}
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@not-a-rootkit @alessandroboron mind if we close in favor of #2739? |
Sure, I checked the PR seems good. I will close this one |
Asana Task/Github Issue:
https://app.asana.com/0/0/1209326067557299/f
Description
This PR removes a duplicated object for “maliciousSiteProtection” for macOS already defined at line 917.
Feature change process:
Additional info:
Site breakage mitigation process:
Brief explanation
Reported URL:
Problems experienced:
Platforms affected:
Tracker(s) being unblocked:
Feature being disabled:
I have referenced the URL of this PR as the "reason" value for the exception (where applicable).
This change is a speculative mitigation to fix reported breakage.
Reference