Update release fetching to optionally match tags with a platform component #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Jan 29, 2025
| client = Octokit::Client.new(access_token: github_token) | ||
|
|
||
| current_page = 1 | ||
| page_size = 25 |
There was a problem hiding this comment.
Happy to change this to something else, but I feel that 25 should be enough to always find the latest public release for a given platform.
samsymons
commented
Jan 29, 2025
| @@ -77,6 +77,31 @@ def self.assert_branch_has_changes(release_branch) | |||
|
|
|||
| changed_files.any? | |||
| end | |||
|
|
|||
| def self.latest_release(repo_name, prerelease, platform = nil, github_token) | |||
There was a problem hiding this comment.
I'll probably change the prerelease parameter name - what it's really doing it controlling whether the function only looks for a public release, or instead looks for the most recent available release regardless of internal/public status.
samsymons
commented
Jan 29, 2025
| # If `prerelease` is true, return the latest release that matches the platform regardless of whether it's public. | ||
| # If `prerelease` is false, then ensure that the release is public. | ||
| matching_release = releases.find do |release| | ||
| (prerelease || !release.prerelease) && (platform.nil? || release.tag_name.end_with?("+#{platform}")) |
There was a problem hiding this comment.
I'm assuming we're fine to check for release.prelease as a way to determine whether a tag is public or internal. It was either this or using a regex to check the tag format, and this feels simpler, providing that it's an assumption we can rely on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://app.asana.com/0/72649045549333/1209266752736135/f
This PR updates the GitHub release lookup logic to look through all releases in our repos and find the relevant release for the platform. It's implemented to keep working the way it always has for now, but when we're ready we would start passing the
platformstring into the lookup function and start getting back releases with a+platformstring at the end.How to test: