Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Don't reset value, if the target input is non-ddg or unknown #748

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dbajpeyi
Copy link
Collaborator

@dbajpeyi dbajpeyi commented Jan 29, 2025

Reviewer: @alistairjcbrown
Asana: https://app.asana.com/0/1205996472158114/1209231072599786/f

Description

Only reset on input events on forms, when the target input is a _matched ddg input field and if it's not unknown match.

Steps to test

Originally reported task is https://app.asana.com/0/1205996472158114/1209231072599786/f. Here's the broken behavior:
Screen Recording 2025-01-27 at 09 31 51

  1. Go to the form mentioned in the task,
  2. Fill out all the identity fields, and then in the "Additional Details, Requests or Questions" enter something, then hit "Enter"
  3. It should not trigger address save prompt (before this PR it used to),
  4. Go back to one of the identities field (e.g name), then add some more text and hit enter again.
  5. It should trigger the save address prompt.

@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/form-save-via-input branch from 8f6d1a0 to 22b180e Compare January 29, 2025 09:35
@dbajpeyi dbajpeyi changed the title fix: don't reset value, if the target input is non-ddg [Form] Don't reset value, if the target input is non-ddg Jan 29, 2025
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/form-save-via-input branch 2 times, most recently from e1a0bd8 to 7f7804d Compare January 30, 2025 13:38
@dbajpeyi dbajpeyi changed the title [Form] Don't reset value, if the target input is non-ddg [Form] Don't reset value, if the target input is non-ddg or unknown Jan 30, 2025
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/form-save-via-input branch from 7f7804d to f8e603e Compare January 30, 2025 13:44
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/form-save-via-input branch from f8e603e to 336906b Compare January 30, 2025 13:53
@dbajpeyi dbajpeyi marked this pull request as ready for review January 30, 2025 13:57
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think playwright is a very good candidate here. It's a very special user interaction that can be replicated with it, and we don't seem to have a similar form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant