[FormAnalyzer] Evaluate checkboxes

[dbajpeyi]

Reviewer: @alistairjcbrown
Asana: NA

Description

Use text from "Stay signed in" and "Remember me" checkboxes to decrease score (aka increase login score). This is a pretty good hint for login forms, where those checkboxes are available.

The approach/change needed:

1. In evaluateElement add a new code block to check if the element matches a checkbox (enabled only)
2. Modify the getShallowText logic to get the related label string (only the first one to keep it simple),
3. Decrease the score if the the label text matches "stay signed in" or "remember me" (case insensitive).

Steps to test

NA

[alistairjcbrown]

This logic of the code makes sense to me 👍
My only concern is we’re adding it because it feels like a good idea, but without any supporting use case for it — are there any forms/tests where we’ve seen a weaker signal and having this improves them?

[dbajpeyi]

@alistairjcbrown
Clarification: This PR IMO is less critical the other ones, so we can continue the review of this after the others where the solutions are clearer.

This just an idea that came as a conversation topic related to https://app.asana.com/0/1200930669568058/1209022781094891/f (I cannot find the comment right now sorry :(). The freshdirect.com example is the one we can try it out with, where the signal without it is -3, and with it is -6. I think the form is clearly a sign-in, even without forgot password, looking at it visually and the "Stay signed in" checkbox is part of that:

If it creates regression or something we will see it in reports, and I can revert it. But i feel confident enough that we need it!