Prevents setting showInMenuBar without actually changing its value
#622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
changed the title
showInMenuBar without changing it in VPNSettings.showInMenuBar without actually changing its value
This was referenced Jan 10, 2024
quanganhdo
approved these changes
Jan 12, 2024
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jan 16, 2024
Task/Issue URL: https://app.asana.com/0/0/1206318102194992/f BSK PR: duckduckgo/BrowserServicesKit#622 iOS PR: duckduckgo/iOS#2317 ## Description This PR brings some adjustments to recent VPN user control improvements. - If you hide the VPN menu app icon when the browser is showing VPN preferences, the VPN preferences "Show VPN in Menu Bar" will be updated dynamically. - The copy shown when right clicking on the VPN icon in the browser's navigation bar was adjusted to include "shortcut" at the end, like for other navigation bar buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206318102194993/f
iOS PR: duckduckgo/iOS#2317
macOS PR: duckduckgo/macos-browser#2043
What kind of version bump will this require?: Patch
Description
Title has it... we just prevent triggering change notifications for
showInMenuBarby setting its value without changing it in user defaults.Testing
Test using the macOS PR.
Internal references:
Software Engineering Expectations
Technical Design Template