Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pixels for sync flows #619

Merged
merged 7 commits into from
Jan 18, 2024
Merged

add pixels for sync flows #619

merged 7 commits into from
Jan 18, 2024

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Jan 8, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1206317026096580/f
iOS PR: duckduckgo/iOS#2332
macOS PR: duckduckgo/macos-browser#2056
What kind of version bump will this require?: Patch

Optional:

Description: Adds debugs Pixels for errors encountered during sync setup flow and sync enabled flow.

Steps to test this PR:

  1. Check that no pixel are sent for errors while no network connection
  2. Hack DDGSync code to throw an error for example from disconnect
  3. make it throw server related error ( noResponseBody, unexpectedStatusCode, unexpectedResponseBody) and check no pixel is fired.
  4. make it throw other types of sync errors and check that the syncLogoutError pixel is sent having as parameter the relevant sync error.
  5. Try other possible pixels: syncSignupError, syncLoginError, syncLogoutError, syncUpdateDeviceError, syncRemoveDeviceError, syncDeleteAccountError, syncLoginExistingAccountError, syncCannotCreateRecoveryPDF(which should have no parameter).

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio requested a review from ayoy January 12, 2024 10:19
@SabrinaTardio SabrinaTardio marked this pull request as ready for review January 16, 2024 12:39
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@SabrinaTardio
Copy link
Contributor Author

Required:

Task/Issue URL: https://app.asana.com/0/0/1206317026096580/f
iOS PR: duckduckgo/iOS#2332
macOS PR: duckduckgo/macos-browser#2056
What kind of version bump will this require?: Patch

Optional:

Description: Adds debugs Pixels for errors encountered during sync setup flow and sync enabled flow.

@SabrinaTardio SabrinaTardio merged commit 7f9eb80 into main Jan 18, 2024
5 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/sync-flow-pixels branch January 18, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants