Malicious site protection iOS #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandroboron
commented
Jan 31, 2025
Package.resolved
Outdated
| @@ -14,8 +14,8 @@ | |||
| "kind" : "remoteSourceControl", | |||
| "location" : "https://github.com/duckduckgo/content-scope-scripts", | |||
| "state" : { | |||
| "revision" : "5a463e35ce86fc11394fe62392d32960de22f7d7", | |||
| "version" : "7.11.0" | |||
| "branch" : "pr-releases/pr-1443", | |||
There was a problem hiding this comment.
I will update this as soon as c-s-s is deployed
alessandroboron
commented
Jan 31, 2025
Package.resolved
Outdated
| @@ -59,8 +59,8 @@ | |||
| "kind" : "remoteSourceControl", | |||
| "location" : "https://github.com/duckduckgo/privacy-dashboard", | |||
| "state" : { | |||
| "revision" : "c52bd5d851b1f8f0482e82b8720852670f525497", | |||
| "version" : "8.1.0" | |||
| "branch" : "pr-releases/pr-319", | |||
There was a problem hiding this comment.
I will update this as soon as the new privacy-dashboard version is deployed
mallexxx
reviewed
Feb 3, 2025
|
|
||
| extension PixelKit: UpdateManagerPixelFiring { | ||
| static func fireFailedToDownloadInitialDatasets(threat: ThreatKind, datasetType: DataManager.StoredDataType.Kind) { | ||
| fire(DebugEvent(MaliciousSiteProtection.Event.failedToDownloadInitialDataSets(category: threat, type: datasetType))) |
There was a problem hiding this comment.
Not a strong opinion here, but I‘d expect it to use the same eventMapping used in the other place, why this has to break the pattern?
There was a problem hiding this comment.
Thinking of it, probably best to delegate the event to the client. In the end the client needs to handle the event anyway and it will be consistent with the eventMapping approach without creating another pattern. Fixed.
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-ios
branch
2 times, most recently
from
2bcd5c5 to
01631b4
Compare
**Required**: Task/Issue URL: https://app.asana.com/0/72649045549333/1209158005098852 iOS PR: duckduckgo/iOS#3837 macOS PR: duckduckgo/macos-browser#3750 What kind of version bump will this require?: Minor **Optional**: Tech Design URL: https://app.asana.com/0/1206329551987282/1209133564224796/f **Description**: This PR exposes a method to fetch Malicious Site Protection Datasets and store last update dates for datasets.
) **Required**: Task/Issue URL: https://app.asana.com/0/1206329551987282/1209242004458518/f iOS PR: duckduckgo/iOS#3891 macOS PR: duckduckgo/macos-browser#3796 What kind of version bump will this require?: Minor **Description**: This PR makes `MaliciousSiteProtection.Event.errorPageShown` `clientSideHit` parameter optional. See dicussion in [AsanaTask](https://app.asana.com/0/1206329551987282/1209242004458518/f)
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-ios
branch
from
8345dda to
a73f098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required:
Task/Issue URL: https://app.asana.com/0/1206329551987282/1209233394358451/f
iOS PR: duckduckgo/iOS#3901
macOS PR: duckduckgo/macos-browser#3750
What kind of version bump will this require?: Major
Optional:
Tech Design URL: https://app.asana.com/0/481882893211075/1207273224076495/f
Description:
Add Malicious Site Protection feature to iOS. This PR has already been reviewed incrementally.
Steps to test this PR:
See iOS and macOS PRs for testing instructions.
Before Merging
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template