Update RMF version matching to ignore build number #1118
Merged
+50
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Dec 6, 2024
Tests/RemoteMessagingTests/Matchers/CommonAppAttributeMatcherTests.swift
Show resolved
Hide resolved
samsymons
commented
Dec 6, 2024
Comment on lines
46
to
48
| min: min.trimmingBuildNumber, | ||
| max: max.trimmingBuildNumber, | ||
| value: value.trimmingBuildNumber, |
There was a problem hiding this comment.
These lines exist to avoid breaking existing messages that already define a build number.
This approach means that build number trimming will happen for all StringRangeMatching attributes, which is currently AppVersionMatchingAttribute and OSMatchingAttribute. But, if you would prefer to keep this change limited to the app version attribute, I can override its initializer and push that logic down there instead.
Alternatively, it could be moved into RangeStringNumericMatchingAttribute instead. We have a few options, let me know what you prefer. Thanks!
There was a problem hiding this comment.
The logic we're applying here is specific to the app version attribute, right? I'd rather see it in the AppVersionMatchingAttribute to limit its reach. Unless you foresee this adjustment to be useful for other strings?
This was referenced Dec 6, 2024
ayoy
approved these changes
Dec 6, 2024
samsymons
deleted the
sam/update-rmf-version-matching-to-ignore-build-number
branch
samsymons
added a commit
to duckduckgo/iOS
that referenced
this pull request
Dec 6, 2024
Task/Issue URL: https://app.asana.com/0/1207619243206445/1208908529122506/f Tech Design URL: CC: Description: This PR updates the iOS app to pull in the BSK app version matching changes added in duckduckgo/BrowserServicesKit#1118.
samsymons
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Dec 6, 2024
Task/Issue URL: https://app.asana.com/0/1207619243206445/1208908529122506/f Tech Design URL: CC: Description: This PR updates the macOS app to pull in the BSK app version matching changes added in duckduckgo/BrowserServicesKit#1118.
samsymons
added a commit
that referenced
this pull request
Dec 19, 2024
* main: (24 commits) change api (#1133) Ensure authToken is present before calling refreshAuthTokenIfNeeded Add 'locale' to report broken site params Add 'locale' to report broken site params Ensure authToken is present before calling refreshAuthTokenIfNeeded Privacy Pro Free Trials - Models and API (#1120) remove MaliciousSiteProtectionSubfeature (#1131) Malware protection 6: Malware integration (#1099) Add underlying error to PrivacyStatsError (#1130) Initial changes for compilation time tracking. (#1111) iOS System level credential provider (#1127) Increase ratio of complete form saves (#1124) Add PrivacyStatsError.failedToClearPrivacyStats (#1128) Update autofill to 16.0.0 (#1122) Update local network routing (#1117) Update RMF version matching to ignore build number (#1118) Fix threading issue between using a Semaphore and async/await (#1115) add experiment test fake feature (#1119) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests from `a603ff9` to `6133e7d` (#1109) experiment default metrics pixels (#1107) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1207619243206445/1208908529122506/f
iOS PR: duckduckgo/iOS#3686
macOS PR: duckduckgo/macos-browser#3635
What kind of version bump will this require?: Patch
Description:
This PR updates the RMF version matching logic to ignore build number. Previously, when you tried to match a version like
1.110.0, it would fail because you needed to know the build number.To fix this, this PR makes the following changes:
versionNumber, notversionAndBuildNumberSteps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template