Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip s3 tests if the secrets are not available #511

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

guenp
Copy link
Collaborator

@guenp guenp commented Feb 11, 2025

I noticed that PR builds from non maintainers (e.g. dependabot) currently fail without secrets access
this PR adds a marker and skips them if s3 secrets are not available

@guenp guenp requested a review from jwills February 11, 2025 22:00
@guenp guenp merged commit 87540aa into master Feb 11, 2025
2 of 20 checks passed
@guenp guenp deleted the guenp/s3-secret-access branch February 11, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants