Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for the stake maturity tests & implementation #977

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Improvements for the stake maturity tests & implementation #977

merged 2 commits into from
Apr 16, 2019
+104 −19

Conversation

dsaveliev
Copy link
Member

Improvements for the stake maturity tests & implementation:

  • Runtime check on stake maturity params
  • Additional test case for the block with an immature stake
  • Typos

Signed-off-by: Dmitry Saveliev [email protected]

@dsaveliev dsaveliev added this to the 0.2 milestone Apr 14, 2019
@dsaveliev dsaveliev requested review from castarco, AM5800, Nizametdinov and a team April 14, 2019 18:42
@dsaveliev dsaveliev self-assigned this Apr 14, 2019
@thothd thothd modified the milestones: 0.2, 0.1 Apr 14, 2019
@dsaveliev dsaveliev force-pushed the leftovers-in-stake-maturity-et-al branch from e5227b5 to c59516f Compare April 15, 2019 07:18
@thothd thothd modified the milestones: 0.1, 0.2 Apr 15, 2019
@dsaveliev dsaveliev force-pushed the leftovers-in-stake-maturity-et-al branch from afa8ece to 5dc897b Compare April 15, 2019 10:40
Nizametdinov
Nizametdinov approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@Nizametdinov Nizametdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5dc897b

@dsaveliev dsaveliev merged commit 2cbf4a4 into dtr-org:master Apr 16, 2019
@dsaveliev dsaveliev deleted the leftovers-in-stake-maturity-et-al branch April 16, 2019 07:55
@thothd thothd modified the milestones: 0.2, 0.1 Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castarco castarco castarco left review comments

@scravy scravy scravy left review comments

@AM5800 AM5800 AM5800 left review comments

@frolosofsky frolosofsky frolosofsky left review comments

@Nizametdinov Nizametdinov Nizametdinov approved these changes

Assignees

@dsaveliev dsaveliev

Labels
proposing
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
7 participants
@dsaveliev @castarco @scravy @AM5800 @Nizametdinov @frolosofsky @thothd