feat: Improve AdditionalPropertiesException message to include bag cl…

…ass name
dshafik · Feb 4, 2025 · d7f0f33 · d7f0f33
1 parent 785e242
commit d7f0f33
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Bag/Exceptions/AdditionalPropertiesException.php b/src/Bag/Exceptions/AdditionalPropertiesException.php
@@ -32,6 +32,6 @@ public function __construct(string $bagClass, Collection $extraProperties)
                 );
             });
 
-        parent::__construct('Additional properties found: '.$extraProperties->implode(', '));
+        parent::__construct(sprintf('Additional properties found for bag (%s): %s', $bagClass, $extraProperties->implode(', ')));
     }
 }
diff --git a/tests/Feature/BagTest.php b/tests/Feature/BagTest.php
@@ -187,7 +187,7 @@
     $value = TestBag::from(name: 'Davey Shafik', age: 40, email: '[email protected]', extra: 'extra', foo: 'bar');
 })->throws(
     AdditionalPropertiesException::class,
-    'Additional properties found: extra, foo'
+    'Additional properties found for bag (Tests\Fixtures\Values\TestBag): extra, foo'
 );
 
 test('it accepts ordered params', function () {

diff --git a/tests/Unit/Pipelines/Pipes/ExtraParametersTest.php b/tests/Unit/Pipelines/Pipes/ExtraParametersTest.php
@@ -58,7 +58,7 @@
 
     $pipe = new ExtraParameters();
     $pipe($input);
-})->throws(AdditionalPropertiesException::class, 'Additional properties found: test');
+})->throws(AdditionalPropertiesException::class, 'Additional properties found for bag (Tests\Fixtures\Values\TestBag): test');
 
 
 test('it errors on non variadic with extra positional parameters', function () {
-Original file line number
+Diff line change
@@ Expand Up @@
                     );
                 });
-            parent::__construct('Additional properties found: '.$extraProperties->implode(', '));
+            parent::__construct(sprintf('Additional properties found for bag (%s): %s', $bagClass, $extraProperties->implode(', ')));
         }
     }