feat: Finalize PHP 8.4 support

dshafik · Jan 3, 2025 · 31a5452 · 31a5452
1 parent 648bc33
commit 31a5452
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -24,7 +24,7 @@ jobs:
           - php-versions: '8.3'
             ignore-platform-reqs: '--ignore-platform-reqs'
           - php-versions: '8.4'
-            ignore-platform-reqs: ''
+            ignore-platform-reqs: '--ignore-platform-reqs'
           - php-versions: '8.4'
             laravel-versions: '^10'
       fail-fast: false

diff --git a/src/Bag/Attributes/Validation/Exists.php b/src/Bag/Attributes/Validation/Exists.php
@@ -14,7 +14,7 @@ class Exists extends Rule implements AttributeInterface
     /**
      * @param string|class-string<Model> $table
      */
-    public function __construct(string $table, string $column = null)
+    public function __construct(string $table, ?string $column = null)
     {
         parent::__construct('exists', $table, $column);
     }

diff --git a/src/Bag/Attributes/Validation/Unique.php b/src/Bag/Attributes/Validation/Unique.php
@@ -14,7 +14,7 @@ class Unique extends Rule implements AttributeInterface
     /**
      * @param string|class-string<Model> $table
      */
-    public function __construct(string $table, string $column = null)
+    public function __construct(string $table, ?string $column = null)
     {
         parent::__construct('unique', $table, $column);
     }