Skip to content

Commit

Permalink
build: move type coverage to code quality workflow, reduce to 98%
Browse files Browse the repository at this point in the history
  • Loading branch information
dshafik committed Jan 4, 2025
1 parent 29c3c55 commit 02fe150
Show file tree
Hide file tree
Showing 3 changed files with 87 additions and 45 deletions.
87 changes: 87 additions & 0 deletions .github/workflows/code-quality.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
name: Code Quality

on:
pull_request:
push:
branches:
- main
tags-ignore:
- '*'

jobs:
scan:
name: Static Analysis with SonarCloud

runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup PHP with Xdebug
uses: shivammathur/setup-php@v2
with:
php-version: '8.3'
coverage: xdebug

- name: Install dependencies with composer
run: composer update --no-ansi --no-interaction --no-progress

- name: Run tests with pest
run: vendor/bin/pest --coverage-clover coverage.xml

- name: Run PHPStan
run: vendor/bin/phpstan analyse --memory-limit=-1 --error-format=json > phpstan.json

- name: SonarCloud Scan
uses: SonarSource/sonarqube-scan-action@master
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

phpstan:
name: Static Anaylsis with PHPStan

runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup PHP with Xdebug
uses: shivammathur/setup-php@v2
with:
php-version: '8.3'
coverage: xdebug

- name: Install dependencies with composer
run: composer update --no-ansi --no-interaction --no-progress

- name: Run PHPStan
run: vendor/bin/phpstan analyse --memory-limit=-1

types:
name: Type Coverage

runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup PHP with Xdebug
uses: shivammathur/setup-php@v2
with:
php-version: '8.3'
coverage: xdebug

- name: Install dependencies with composer
run: composer update --no-ansi --no-interaction --no-progress

- name: Run type coverage with pest
run: vendor/bin/pest --type-coverage --min=98 --memory-limit=-1
42 changes: 0 additions & 42 deletions .github/workflows/sonarcloud.yaml

This file was deleted.

3 changes: 0 additions & 3 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,3 @@ jobs:

- name: Run tests with pest
run: vendor/bin/pest --parallel --coverage --min=80

- name: Run type coverage with pest
run: vendor/bin/pest --type-coverage --min=99 --memory-limit=-1

0 comments on commit 02fe150

Please sign in to comment.