Fix uploads race #91
Merged
Fix uploads race #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for spending the time to research this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #87
This took quite a bit to understand what was happening... and ultimately looks like it was a typo.
req.on("close"...was racing withbb.on("finish"..., and it seems that is becausereq.on("close"...should actually bebb.on("close"....One note about the current setup of
bb.on("finish")andbb.on("close")is that (if I am understanding correctly) it is possible that we would move the temp files into place before the file stream buffer is actually finished/closed. See the answer from mscdex (busboy author).