Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support providing OAuth 2 bearer tokens directly to the plugin #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jlawrienyt
Copy link

This is to support a use case where a Vault plugin is being used to provide secrets to Drone, and using the Google Cloud Secrets Engine which provides either an OAuth 2 Token or a base-64 encoded service account json key, neither of which will currently work with this plugin.

I'm happy to update the plugin docs as well, though I'm not sure where the source for those is.

@techknowlogick
Copy link

The plugin docs can be found here: https://github.com/drone/drone-plugin-index

@jlawrienyt
Copy link
Author

The build failures are due to docker.com rate limiting:

Step 1/12 : FROM alpine:3.12 as alpine
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
exit status 1

Any thoughts on how to get the build working? I see some discussion over in discourse, but I'm not sure how it applies to builds running at cloud.drone.io.

@lafriks
Copy link

lafriks commented Dec 2, 2021

Not much can be done sadly :/

@lafriks
Copy link

lafriks commented Dec 2, 2021

Ok, restarted job and got lucky 😁

@tonglil
Copy link
Member

tonglil commented Dec 2, 2021

The suggestion here was to remove the dryrun step.

@jlawrienyt
Copy link
Author

I've created a draft PR in the plugin docs repo documenting the update. Anything else that needs to be done here before it can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants