Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#484 Add GSClient timeout support #485

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

no implicit optional

9b034b7
Select commit
Loading
Failed to load commit list.
Open

#484 Add GSClient timeout support #485

no implicit optional
9b034b7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 30, 2024 in 0s

93.2% (-1.3%) compared to 7f1a5dc

View this Pull Request on Codecov

93.2% (-1.3%) compared to 7f1a5dc

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.2%. Comparing base (7f1a5dc) to head (9b034b7).

Files with missing lines Patch % Lines
cloudpathlib/gs/gsclient.py 85.7% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #485     +/-   ##
========================================
- Coverage    94.4%   93.2%   -1.3%     
========================================
  Files          23      23             
  Lines        1776    1780      +4     
========================================
- Hits         1678    1659     -19     
- Misses         98     121     +23
Files with missing lines Coverage Δ
cloudpathlib/gs/gsclient.py 89.6% <85.7%> (-1.9%) ⬇️

... and 2 files with indirect coverage changes

View more details on Codecov