-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud implementation of shutil.copy and shutil.copytree #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Draft of cloudpathlib.copy, that replicates shutil.copy * Import only PathLike from os * Reuse _local_to_cloud_copy for cached files * try to use the intended cached _local version * Update cloudshutil.py * Implemented the CloudPath methods: upload_from, copy, copytree * Add docstrings * Fix indentation * fix unnecessary imports * Fix typing issues * Allow CloudPath.copy to a directory as well
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
========================================
+ Coverage 93.5% 93.9% +0.4%
========================================
Files 21 21
Lines 1119 1177 +58
========================================
+ Hits 1047 1106 +59
+ Misses 72 71 -1
|
Hey @pjbull, indeed, sorry for leaving it unfinished but it's a very busy period! Glad to have contributed! |
jayqi
requested changes
May 19, 2021
This was referenced May 20, 2021
pjbull
commented
May 20, 2021
@jayqi This is ready for re-review:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like @genziano was busy (thanks for the initial work!), so I moved over his WIP from #125 to this branch.
@BenAsaf feel free to pick it up from here.
Moved over PR from #125:
Draft of cloudpathlib.copy, that replicates shutil.copy
Import only PathLike from os
Reuse _local_to_cloud_copy for cached files
try to use the intended cached _local version
Update cloudshutil.py
Implemented the CloudPath methods: upload_from, copy, copytree
Add docstrings
Fix indentation
fix unnecessary imports
Fix typing issues
Allow CloudPath.copy to a directory as well
Closes #58
Closes #108