overrides option #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to see this functionality added as well. |
|
Any news about this option? Will it be reviewed? |
TimmiT93
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option - "overrides" that is an object used like a hash table. The "key" of the hash table is the package name and thus the folder name under node_modules. The "value" of the hash table is an array of file paths to add to the result set rather than the main file. The path is expected to be relative within the node package sub-directory (as if the present working directory is /node_modules/packageName/). Kind of modeled after main-bower-files overrides, but took one level of object out of the mix. I kind of need this functionality to use this in my build process, hope the implementation is Ok, let me know if you would like changes or your thoughts. Thanks for the great work.