Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct darwin paths to .dylib #29

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Correct darwin paths to .dylib #29

merged 1 commit into from
Feb 8, 2019

Conversation

chee
Copy link
Contributor

@chee chee commented Feb 7, 2019

.dynlib isn't a thing! also the file format is .\d+.dylib rather than .dylib.\d+ c:

.dynlib isn't a thing! also the file format is `.\d+.dylib` rather than `.dylib.\d+` c:
@chee
Copy link
Contributor Author

chee commented Feb 7, 2019

This works like this on my macos system, but i did have to install readline with homebrew and then do brew link readline --force.

On macos by default, /usr/lib/libreadline.dylib is a symlink to libedit.3 which is a basket of lols.

So far i haven't run into any problems from programs expecting getting libreadline when they asked for libreadline but i'm sure the --force install is not a recommended path.

The default path to the non-force-linked brew installed libreadline would be /usr/local/Cellar/readline/8.0.0/lib/, so there'd need to be an entry in library-paths for every readline version unless a glob was used.

However, this would be the normal name and location for someone who has downloaded, ./configure'd make'd and sudo make install'd readline themselves on a mac, so I feel this PR is valuable.

I think this should help with #20. 😊

@drforr drforr merged commit 3aa61f1 into drforr:master Feb 8, 2019
@chee chee deleted the patch-1 branch February 8, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants