refactor(workflow): rm code and speed up workflows #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
commented
Jul 2, 2024
| working-directory: ${{env.WORKING_DIRECTORY}} | ||
|
|
||
| build-docs: | ||
| if: needs.files-changed.outputs.frontend-docs == 'true' |
There was a problem hiding this comment.
This was always the only different file filter list for each workflow file.
roschaefer
changed the title
roschaefer
changed the title
roschaefer
changed the title
Motivation ---------- Performance: We will run only *one* detect file changes job for each subfolder. Maintenance: Much less code. Safetey: If anything under `./github/workflows` has changed, run all jobs. It's dangerous to hard-code the workflow name in the file-filters list. How to test ----------- 1. Check the status checks for this PR
mahula
approved these changes
Jul 2, 2024
roschaefer
commented
Jul 2, 2024
| @@ -3,26 +3,7 @@ name: "dreammall:test:code with defined tests & linters" | |||
| on: [push,pull_request_target] | |||
|
|
|||
| jobs: | |||
| # only (but most important) job from this workflow required for pull requests | |||
There was a problem hiding this comment.
That one had a file filter list of **/* - pointless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Performance: We will run only one detect file changes job for each subfolder.
Maintenance: Much less code.
Safety: If anything under
./github/workflowshas changed, run all jobs. It's dangerous to hard-code the workflow name in the file-filters list.How to test