refactor(frontend): refactor tests and stories for sidebar #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ogerly
changed the title
|
|
Mogge
reviewed
Jun 27, 2024
Mogge
reviewed
Jun 27, 2024
Mogge
reviewed
Jun 27, 2024
|
I have the ListWithNavigationDrawer component in the top and bottom menus. at this point it only needs to be filled. |
2024-06-2808-49-50-ezgif.com-crop-video.mp4 |
ogerly
commented
Jul 3, 2024
ogerly
requested review from
roschaefer,
Bettelstab,
Elweyn,
maeckes1 and
sebastian2357
|
i have added jsdom which fixes our error in the frontend/src/components/buttons/CreateButtonMobile.test.ts. the tests should now throw fewer warnings. |
ogerly
force-pushed
the
709-6-Toggle-In-TopMenu
branch
from
7da02c3 to
06028ad
Compare
This was referenced Jul 3, 2024
roschaefer
previously requested changes
Jul 3, 2024
There was a problem hiding this comment.
Could we please pair-program on this one @ogerly?
Here's a quick review already.
|
Please beware that there is
#1273 which is
supposed to be merged!
Alexander Friedland ***@***.***> schrieb am Mi., 3. Juli
2024, 15:24:
… ***@***.**** commented on this pull request.
------------------------------
In frontend/src/components/menu/BottomMenu.test.ts
<#1188 (comment)>
:
> + // describe.only('drawer functionality', async() => {
+ // it('opens the drawer when Circle element is clicked', async () => {
+ // const circleButton = wrapper.findComponent({ name: 'Circle' })
+ // const drawerComponent = wrapper.findComponent({ name: 'VNavigationDrawer' })
+
+ // // Initialzustand des Drawers überprüfen
+ // expect(drawerComponent.vm.modelValue).toBe(false)
+
+ // // Circle-Element klicken und Drawer-Status überprüfen
+ // await circleButton.trigger('click')
+ // await flushPromises()
+
+ // expect(drawerComponent.vm.modelValue).toBe(true)
+ // })
+ // })
+
removed
—
Reply to this email directly, view it on GitHub
<#1188 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZCEGATHOW5H45XQFNYUYTZKP3QHAVCNFSM6AAAAABJR6IJ5KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJWGQ2DKNZRGU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Bettelstab
force-pushed
the
709-6-Toggle-In-TopMenu
branch
from
9d684b7 to
bf9400a
Compare
Merge branch 'master' into 709-6-Toggle-In-TopMenu resolve review - robert resolve review - robert fix eslint in backend fix unit update after rebase fix storybook error jsdom fix lint resolve conclict from - git rebase origin/master fix lint Update frontend/src/components/menu/BottomMenu.vue Update frontend/src/components/menu/BottomMenu.vue Update frontend/src/components/menu/BottomMenu.vue fix test:lint add @typescript-eslint/no-unsafe-argument fix test:unit fix test:lint fix stories remove unused code camera button position in percent fix lint eslint, test update add cursor:pointer an camera icon in top und bottom menu add changes ListWithNavigationDrawer saved fix update, lint, test add ListWithNavigationDrawer in bottom menu and topmenu remove MessageIndicator NewsIndicator file in bottom menu fix eslint resolve conclict from - git rebase origin/master all tests, lint fix test drawer buttom menu, commented out resolve conclict from - git rebase origin/master resolve conclict from - git rebase origin/master resolve conclict from - git rebase origin/master remove timeout for refetch rooms more logs, use setRooms to update state delay refetch open rooms 1 min, more console to debug console to debug linting error handling refetch open rooms handle click event on open room type startTime in Room/OpenRoom is string resolve conclict from - git rebase origin/master Add rooms store. resolve conclict from - git rebase origin/master Fix linting resolve conclict from - git rebase origin/master resolve conclict from - git rebase origin/master fix style fix eslint remove space lint fix resolve conclict from - git rebase origin/master remove render files remove only from test resolve conclict from - git rebase origin/master change classname resolve conclict from - git rebase origin/master resolve conclict from - git rebase origin/master fix test and lint and update add snapshot resolve conflicts, remove Navigatin Drawer Component remove unused prop Update frontend/src/components/vuetify/NavigationDrawer.vue Co-authored-by: Moriz Wahl <[email protected]> Update frontend/src/components/vuetify/NavigationDrawer.vue Co-authored-by: Moriz Wahl <[email protected]> add snapshots remove unused file add locale, change tsconfig coverage to 96% fix lint add snapshots, ??render config??? resolve conclict from - git rebase origin/master fix lint, fix test clear imports Add Snapshots clear imports Add Snapshot, fix lint Add SearchField Component fix clear imports change files and folders for atomic design add ListWithNavigationDrawer Component, change files and folders for atomic design fix test add snapshot fix lint NavigationDrawer Component fix test and lint Add ListElement Component
Bettelstab
force-pushed
the
709-6-Toggle-In-TopMenu
branch
from
bf9400a to
2eaa8ca
Compare
Elweyn
changed the title
Merge branch 'master' into 709-6-Toggle-In-TopMenu resolve review - robert resolve review - robert fix eslint in backend fix unit update after rebase fix storybook error jsdom fix lint resolve conclict from - git rebase origin/master fix lint Update frontend/src/components/menu/BottomMenu.vue Update frontend/src/components/menu/BottomMenu.vue Update frontend/src/components/menu/BottomMenu.vue fix test:lint add @typescript-eslint/no-unsafe-argument fix test:unit fix test:lint fix stories remove unused code camera button position in percent fix lint eslint, test update add cursor:pointer an camera icon in top und bottom menu add changes ListWithNavigationDrawer saved fix update, lint, test add ListWithNavigationDrawer in bottom menu and topmenu remove MessageIndicator NewsIndicator file in bottom menu fix eslint resolve conclict from - git rebase origin/master all tests, lint fix test drawer buttom menu, commented out resolve conclict from - git rebase origin/master resolve conclict from - git rebase origin/master resolve conclict from - git rebase origin/master remove timeout for refetch rooms more logs, use setRooms to update state delay refetch open rooms 1 min, more console to debug console to debug linting error handling refetch open rooms handle click event on open room type startTime in Room/OpenRoom is string resolve conclict from - git rebase origin/master Add rooms store. resolve conclict from - git rebase origin/master Fix linting resolve conclict from - git rebase origin/master resolve conclict from - git rebase origin/master fix style fix eslint remove space lint fix resolve conclict from - git rebase origin/master remove render files remove only from test resolve conclict from - git rebase origin/master change classname resolve conclict from - git rebase origin/master resolve conclict from - git rebase origin/master fix test and lint and update add snapshot resolve conflicts, remove Navigatin Drawer Component remove unused prop Update frontend/src/components/vuetify/NavigationDrawer.vue Co-authored-by: Moriz Wahl <[email protected]> Update frontend/src/components/vuetify/NavigationDrawer.vue Co-authored-by: Moriz Wahl <[email protected]> add snapshots remove unused file add locale, change tsconfig coverage to 96% fix lint add snapshots, ??render config??? resolve conclict from - git rebase origin/master fix lint, fix test clear imports Add Snapshots clear imports Add Snapshot, fix lint Add SearchField Component fix clear imports change files and folders for atomic design add ListWithNavigationDrawer Component, change files and folders for atomic design fix test add snapshot fix lint NavigationDrawer Component fix test and lint Add ListElement Component
Bettelstab
changed the title
Elweyn
approved these changes
Jul 10, 2024
roschaefer
added a commit
that referenced
this pull request
Jul 10, 2024
Motivation
----------
When I `npm install` and `npm run dev` in `frontend/` I see:
```
(node:4820) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
✘ [ERROR] Cannot start service: Host version "0.21.5" does not match binary version "0.20.2"
1 error
failed to load config from /home/robert/Development/dreammall/dreammall.earth/frontend/vite.config.ts
/home/robert/Development/dreammall/dreammall.earth/frontend/node_modules/vite/node_modules/esbuild/lib/main.js:968
if (error) return callback(new Error(error), null);
^
```
The PR #1188 has unrelated code. The `package-lock.json` was merged
although it has nothing to do with the changes in the PR.
When I `git checkout ce3cd41^ -- frontend/package-lock.json`
the error is gone locally.
How to test
-----------
1. `cd frontend/`
2. `npm install`
3. `npm run dev`
4. Server running at http://localhost:3000/
mahula
pushed a commit
that referenced
this pull request
Jul 10, 2024
* fix(frontend): revert to old `package-lock.json`
Motivation
----------
When I `npm install` and `npm run dev` in `frontend/` I see:
```
(node:4820) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
✘ [ERROR] Cannot start service: Host version "0.21.5" does not match binary version "0.20.2"
1 error
failed to load config from /home/robert/Development/dreammall/dreammall.earth/frontend/vite.config.ts
/home/robert/Development/dreammall/dreammall.earth/frontend/node_modules/vite/node_modules/esbuild/lib/main.js:968
if (error) return callback(new Error(error), null);
^
```
The PR #1188 has unrelated code. The `package-lock.json` was merged
although it has nothing to do with the changes in the PR.
When I `git checkout ce3cd41^ -- frontend/package-lock.json`
the error is gone locally.
How to test
-----------
1. `cd frontend/`
2. `npm install`
3. `npm run dev`
4. Server running at http://localhost:3000/
* trigger ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.