Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecm variations #99

Merged
merged 1 commit into from
Feb 11, 2025
Merged

ecm variations #99

merged 1 commit into from
Feb 11, 2025

Conversation

drbergman
Copy link
Owner

@drbergman drbergman commented Feb 9, 2025

  • initialize ecm using an xml and thus allow for variations
  • add dep PhysiCellECMCreator.jl which manages the use of the xml
  • add ecm creator to docs and testing
  • actually put database_upgrades in documentation
  • move cell speed etc from VCTLoader.jl to VCTAnalysis/motility.jl
  • enable upgrade to v0.0.15 with ic_ecm_variation_id
  • do not need the RERTURNING clause in init the ic_cell/ic_ecm dbs

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 97.54386% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.85%. Comparing base (d5119a4) to head (4eb26ea).
Report is 2 commits behind head on development.

Files with missing lines Patch % Lines
src/VCTDeletion.jl 88.88% 2 Missing ⚠️
src/VCTAnalysis/motility.jl 97.36% 1 Missing ⚠️
src/VCTClasses.jl 92.85% 1 Missing ⚠️
src/VCTConfiguration.jl 98.36% 1 Missing ⚠️
src/VCTExport.jl 90.00% 1 Missing ⚠️
src/VCTVariations.jl 97.72% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development      #99      +/-   ##
===============================================
+ Coverage        94.68%   94.85%   +0.17%     
===============================================
  Files               25       27       +2     
  Lines             3499     3696     +197     
===============================================
+ Hits              3313     3506     +193     
- Misses             186      190       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- initialize ecm using an xml and thus allow for variations
- add dep PhysiCellECMCreator.jl which manages the use of the xml
- add ecm creator to docs and testing
- actually put database_upgrades in documentation
- move cell speed etc from VCTLoader.jl to VCTAnalysis/motility.jl
- enable upgrade to v0.0.15 with ic_ecm_variation_id
- do not need the RERTURNING clause in init the ic_cell/ic_ecm dbs
@drbergman drbergman changed the title got ecm variations ready to go? ecm variations Feb 11, 2025
@drbergman drbergman merged commit 8bc5c35 into development Feb 11, 2025
8 checks passed
@drbergman drbergman deleted the ic-ecm-xml branch February 11, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant