http: fix waker dead improperly due to lifetime mismatch

The mio waker must be alive to get the notification delivered, otherwise the inflight notification may get dropped silently. Signed-off-by: Liu Jiang <[email protected]> Signed-off-by: Gao Xiang <[email protected]>
dragonflyoss · Apr 14, 2022 · 9f62a71 · 9f62a71
1 parent d73e271
commit 9f62a71
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/api/src/http.rs b/api/src/http.rs
@@ -399,8 +399,8 @@ pub fn start_http_thread(
     let socket_path = PathBuf::from(path);
 
     let mut pool = Poll::new()?;
-    let waker = Waker::new(pool.registry(), EXIT_TOKEN)?;
-    let waker = Arc::new(waker);
+    let waker = Arc::new(Waker::new(pool.registry(), EXIT_TOKEN)?);
+    let waker2 = waker.clone();
     let mut server = HttpServer::new(socket_path).map_err(|e| {
         if let ServerError::IOError(e) = e {
             e
@@ -463,8 +463,9 @@ pub fn start_http_thread(
                     }
                 }
             }
-
             info!("http-server thread exits");
+            // Keep the Waker alive to match the lifetime of the poll loop above
+            drop(waker2);
             Ok(())
         })?;