Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colours according to spec #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented May 25, 2022

Using the Dracula spec and Pygments docs as a reference…

@danielcs88 @zenorocha @luxonauta This is much more accurate now…

@danielbayley danielbayley changed the title Fix Generic.Deleted red Fix colours according to spec May 25, 2022
Copy link
Contributor

@danielcs88 danielcs88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielbayley Daniel, can you provide a screenshot to see the changes?

@danielbayley
Copy link
Member Author

@danielbayley Daniel, can you provide a screenshot to see the changes?

@danielcs88 Sure… So this app is SnippetsLab, it uses Pygments for syntax highlighting.

Here are before and after screenshots for Markdown, Ruby, and Python, respectively:

md-b4

md-after


rb-b4

rb-after


py-b4

py-after

@vincentbernat
Copy link

Also, Generic.Output is far more readable in this new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants