Modernize the plugin internals #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoux
changed the title
|
@dpelle, do you agree with the TODO list? |
Moved all functions from the monolithic plugin file to autoload file Also moved all server management stuff to its proper file
Add the ability to show error at point is the preview window Also add :LanguageToolErrorAtPoint command to use this feature Fixes dpelle#16
Fix some spelling mistakes Updates due configuration changes Add license to syntax file
Preparation step for the use of the server to know the supported languages <`4:#:footer`>
You can now fix errors, you have two ways to do this:
* Go to the error and use :[count]LanguageToolFixAtPoint
This will fix error with the [count]th correction
* Go to the error, hit :LanguageToolErrorAtPoint
then put the cursor on the correction you want and hit <CR>
Changed fix mistake shortcut to 'f' for consistency
BREAKING CHANGE: LanguageTool config now goes through g:languagetool, and you can configure the plugin to have different behavior depending on the filetype (see documentation)
This is done to prevent error preview buffer and summary window buffer to clash when using both of them
Add g:languagetool_summary_flags and g:languagetool_preview_flags to change how errors are printed in these two windows.
|
I'm closing this PR as the version of the plugin I run now only supports Neovim, if you want to check it out, it's here : https://github.com/vigoux/LanguageTool.nvim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR in a list of small ones (to come).
The objective here is to 'modernize' the plugin by adapting it to new apis, and maybe use async
jobcontrol ofvimandnvim.Another objective of this PR is to mitigate the performance issue of LT, by using all its functionalities, like ignoring markup...
TODOS:
datafield instead oftextfield to prepare for preprocessing document to distinguish markup and textjob-controlto send text to the server, and callback to check response<Plug>mappings to avoid remappingspellLanguageTool should honour ]s and [s mappings (feature request) #15